Allow to add HTTP headers on top of ApolloClient ones #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
reviewed
Mar 14, 2023
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ApolloRequest.kt
Outdated
Show resolved
Hide resolved
|
Bad news everyone, this broke this test because interceptors work with |
|
These tests failing lead me to a somewhat better solution leaving the public API untouched 👌 . |
BoD
reviewed
Mar 15, 2023
| @@ -185,8 +182,23 @@ object SchemaDownloader { | |||
|
|
|||
| inline fun <reified T> Any?.cast() = this as? T | |||
|
|
|||
| private fun getIntrospectionQuery(includeDeprecatedInputFieldsAndArguments: Boolean): String { | |||
| val includeDeprecated = if (includeDeprecatedInputFieldsAndArguments) "(includeDeprecated: true)" else "" | |||
| fun getIntrospectionQuery(specVersion: SpecVersion): String { | |||
There was a problem hiding this comment.
Some unrelated commit got in the way
There was a problem hiding this comment.
Good catch. I just rebased again. Should be good this time.
martinbonnin
force-pushed
the
add-headers
branch
from
a2975c2
to
89e9d69
Compare
martinbonnin
added a commit
that referenced
this pull request
Mar 28, 2023
* allow to add HTTP headers on top of ApolloClient ones * keep binary compatibility * update apiDump * fix adding several headers * udate apiDump
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4753