Move cache creation to be lazy #4781
Conversation
✅ Deploy Preview for apollo-android-docs canceled.
|
| return MemoryCacheFactory().create() | ||
| } | ||
| }).build() | ||
| assertNull(cacheCreateThreadName) |
| private val cache: OptimisticCache = OptimisticCache().chain(normalizedCacheFactory.createChain()) as OptimisticCache | ||
| // Keeping this as lazy to avoid accessing the disk at initialization which usually happens on the main thread | ||
| private val cache: OptimisticCache by lazy { | ||
| OptimisticCache().chain(normalizedCacheFactory.createChain()) as OptimisticCache |
There was a problem hiding this comment.
Is lazy thread safe? I remember reading something or some rumour saying lazy was generating a lot of bytecode. Might be worth making it a lateninit and use regular locks?
There was a problem hiding this comment.
By default by lazy uses a synchronized block on the JVM and on native it looks like it's using a Lock.
For the bytecode yes it can be "verbose" (👀 this from 2019!)
Pushed a commit doing this manually LMKWYT!
There was a problem hiding this comment.
Looks probably ok to keep lazy here according to Chet guidance. It's quite an heavy object and allocation is done only once so both work for me!
| if (_cache == null) { | ||
| lock.write { | ||
| if (_cache == null) { | ||
| _cache = OptimisticCache().chain(normalizedCacheFactory.createChain()) as OptimisticCache | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
That doesn't work though. The whole if {} needs to be locked or you could create 2 caches
There was a problem hiding this comment.
Ah never mind, there's double if !
BoD
force-pushed
the
lazy-cache-creation
branch
from
6161a94
to
cc5a2ec
Compare
Related to #4780