Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: ignore hardcoded @include(if: false) directives #4795

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

martinbonnin
Copy link
Contributor

Closes #4772

@martinbonnin martinbonnin requested a review from BoD as a code owner March 24, 2023 15:03
@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 68b1655
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/641dbba703d02400084d45ef

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin added this pull request to the merge queue Mar 24, 2023
Merged via the queue into main with commit 0f8ea08 Mar 24, 2023
@martinbonnin martinbonnin deleted the issue4772 branch March 24, 2023 16:07
martinbonnin added a commit that referenced this pull request Mar 28, 2023
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded directive (@skip) when used with normalized cache results in RunTimeException.
2 participants