Add % to reserved characters to encode in URL #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slinstacart: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
|
Just in time for next release, thanks! PS: we might want to switch to a full-blown uri library like https://github.com/eygraber/uri-kmp/ |
martinbonnin
approved these changes
Mar 27, 2023
Merged
martinbonnin
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Add % to reserved characters to encode * Remove unused variable * Fix test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the library is not encoding the '%' character in GET parameters, i.e if I send a parameter string of '80%' this isn't parsed properly since it needs to be encoded to '%25'
This is a bug in UrlEncode.kt where it looks like it was introduced here in this PR which was originally encoding every character.