Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart subscriptions: send an error on critical errors #4807

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

martinbonnin
Copy link
Contributor

If we get an error payload, return an exception to the caller:

--graphql
content-type: application/json

{"errors":[{"message":"cannot read message from websocket","extensions":{"code":"WEBSOCKET_MESSAGE_ERROR"}}],"done":true}

@martinbonnin martinbonnin requested a review from BoD as a code owner March 28, 2023 11:09
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 5872000
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6422f1abafe2b600086d2726

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit a0f4867 Mar 28, 2023
@martinbonnin martinbonnin deleted the multipart-errors branch March 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants