Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: fix extension printing #4814

Merged
merged 4 commits into from
Mar 30, 2023
Merged

AST: fix extension printing #4814

merged 4 commits into from
Mar 30, 2023

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Mar 30, 2023 •
edited

closes #4797

@martinbonnin martinbonnin requested a review from BoD as a code owner March 30, 2023 12:15
@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 7855bda
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64258332cebbba000837a9ac

BoD
BoD approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

libraries/apollo-ast/src/main/kotlin/com/apollographql/apollo3/ast/locations.kt Outdated
filePath = null
)

fun GQLDefinition.removeLocation1(): GQLDefinition = when(this) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is to avoid a clash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially thought so but it's not needed, I'll change that

@martinbonnin martinbonnin added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit c344a4a Mar 30, 2023
@martinbonnin martinbonnin deleted the fix-extension-printing branch March 30, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use GQLDocument.toUtf8() on documents that include the extend keyword
2 participants
@martinbonnin @BoD