[3.x] update Kotlin to 1.9 #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed Kotlin 1.9 to support new XCode command line options, which in turns needed other things
BoD
reviewed
Nov 29, 2023
|
Had to change a bunch of things and bump the kotlin-stdlib so it's not a transparent change but this is life. software evolves! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed Kotlin 1.9 to support new XCode command line options, which in turns needed other things.
I think this is mostly transparent for users (languageVersion is still 1.5) but if we're ever doing a 3.x maintenance version, we should call this out in the changelog.Welp, I had to bump the Kotlin stdlib to 1.9.20 as well or
compileCommonMainMetadatafails. Definitely something to call out in the changelog. We now require Kotlin 1.8 to compile against apollo-kotlin (see c1e24e1)