[compiler] validate operation directives & enforce presence of the nullability directive definitions

docs/source/advanced/nullability.mdx

@@ -252,6 +252,15 @@ This is used for backward compatibility for clients where this was the default b
 directive @ignoreErrors on QUERY | MUTATION | SUBSCRIPTION
 ```
 
+To enable it, import it like `@catch`, `CatchTo` and `@semanticNonNull`:
+
+```graphql
+extend schema @link(
+  url: "https://specs.apollo.dev/nullability/v0.1",
+  import: ["@catch", "CatchTo", "@semanticNonNull", "@ignoreErrors"]
+)
+```
+
 Enabling error aware parsing and adding `@ignoreErrors` to all your operations is a no-op. You can then remove `@ignoreErrors` from your operations progressively. 
 
 ## Decision flowchart 

libraries/apollo-ast/api/apollo-ast.api

@@ -938,6 +938,7 @@ public final class com/apollographql/apollo3/ast/Schema {
 	public static final field FIELD_POLICY_PAGINATION_ARGS Ljava/lang/String;
 	public static final field IGNORE_ERRORS Ljava/lang/String;
 	public static final field NONNULL Ljava/lang/String;
+	public static final field ONE_OF Ljava/lang/String;
 	public static final field OPTIONAL Ljava/lang/String;
 	public static final field REQUIRES_OPT_IN Ljava/lang/String;
 	public static final field SEMANTIC_NON_NULL Ljava/lang/String;

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/Schema.kt

@@ -205,6 +205,8 @@ class Schema internal constructor(
     const val OPTIONAL = "optional"
     const val REQUIRES_OPT_IN = "requiresOptIn"
 
+    @ApolloExperimental
+    const val ONE_OF = "oneOf"
     @ApolloExperimental
     const val CATCH = "catch"
     @ApolloExperimental

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt

@@ -29,7 +29,7 @@ fun List<GQLDirective>.findSpecifiedBy() = firstOrNull { it.name == "specifiedBy
           }
     }
 
-fun List<GQLDirective>.findOneOf() = any { it.name == "oneOf" }
+fun List<GQLDirective>.findOneOf() = any { it.name == Schema.ONE_OF }
 
 @ApolloInternal
 fun List<GQLDirective>.findOptInFeature(schema: Schema): String? = filter { schema.originalDirectiveName(it.name) == Schema.REQUIRES_OPT_IN }

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/ExecutableValidationScope.kt

@@ -394,6 +394,16 @@ internal class ExecutableValidationScope(
         ))
       }
     }
+    directives.forEach {
+      validateDirective(it, this) {
+        issues.add(
+            OtherValidationIssue(
+                "Operation directive arguments cannot contain variables",
+                it.variable.sourceLocation
+            )
+        )
+      }
+    }
   }
 
   private fun List<GQLSelection>.collectFragmentSpreads(): Set<String> {

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/SchemaValidationScope.kt

@@ -132,9 +132,9 @@ internal fun validateSchema(definitions: List<GQLDefinition>, requiresApolloDefi
     }
   }
 
-  directiveDefinitions["oneOf"]?.let {
+  directiveDefinitions[Schema.ONE_OF]?.let {
     if (it.locations != listOf(GQLDirectiveLocation.INPUT_OBJECT) || it.arguments.isNotEmpty() || it.repeatable) {
-      issues.add(IncompatibleDirectiveDefinition("oneOf", "directive @oneOf on INPUT_OBJECT", it.sourceLocation))
+      issues.add(IncompatibleDirectiveDefinition(Schema.ONE_OF, "directive @oneOf on INPUT_OBJECT", it.sourceLocation))
     }
   }
 

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/ValidationCommon.kt

@@ -127,11 +127,20 @@ internal fun ValidationScope.validateDirective(
   val directiveDefinition = directiveDefinitions[directive.name]
 
   if (directiveDefinition == null) {
-    if (directive.name == "oneOf") {
-      // We require full schemas to allow the usage of @oneOf
-      issues.add(UnknownDirective("'@${directive.name}' directive must be defined in the schema to be used", directive.sourceLocation, requireDefinition = true))
-    } else {
-      issues.add(UnknownDirective("Unknown directive '@${directive.name}'", directive.sourceLocation, requireDefinition = false))
+    when (val originalName = originalDirectiveName(directive.name)) {
+      Schema.ONE_OF,
+      Schema.CATCH,
+      Schema.SEMANTIC_NON_NULL,
+      Schema.IGNORE_ERRORS,
+      -> {
+        // Require full schemas to allow the usage of newest directives
+        // See https://github.com/apollographql/apollo-kotlin/issues/2673
+        issues.add(UnknownDirective("No directive definition found for '@${originalName}'", directive.sourceLocation, requireDefinition = true))
+      }
+
+      else -> {
+        issues.add(UnknownDirective("Unknown directive '@${directive.name}'", directive.sourceLocation, requireDefinition = false))
+      }
     }
 
     return

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/definitions.kt

@@ -334,5 +334,5 @@ Never throw on field errors.
 
 This is used for backward compatibility for clients where this was the default behaviour.
 ""${'"'}
-directive @ignoreFieldErrors on QUERY | MUTATION | SUBSCRIPTION
+directive @ignoreErrors on QUERY | MUTATION | SUBSCRIPTION
 """.trimIndent()

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/introspection/introspection_reader.kt

@@ -31,6 +31,7 @@ import com.apollographql.apollo3.ast.GQLType
 import com.apollographql.apollo3.ast.GQLUnionTypeDefinition
 import com.apollographql.apollo3.ast.GQLValue
 import com.apollographql.apollo3.ast.HOST_FILESYSTEM
+import com.apollographql.apollo3.ast.Schema
 import com.apollographql.apollo3.ast.SourceLocation
 import com.apollographql.apollo3.ast.parseAsGQLValue
 import kotlinx.serialization.KSerializer
@@ -488,7 +489,7 @@ private class GQLDocumentBuilder(private val introspectionSchema: IntrospectionS
         directives = if (isOneOf == true) {
           listOf(
               GQLDirective(
-                  name = "oneOf",
+                  name = Schema.ONE_OF,
                   arguments = emptyList()
               )
           )

tests/catch/src/main/graphql/shared/schema.graphqls

@@ -1,4 +1,4 @@
-extend schema @link(url: "https://specs.apollo.dev/nullability/v0.1", import: ["@semanticNonNull", "@catch", "CatchTo"])
+extend schema @link(url: "https://specs.apollo.dev/nullability/v0.1", import: ["@semanticNonNull", "@catch", "CatchTo", "@ignoreErrors"])
 
 type Query {
   nullable: Int