Add validation to check schema definitions are compatible with the bundled ones #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
reviewed
Dec 7, 2023
libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/gqldirective.kt
Outdated
Show resolved
Hide resolved
…n nullability are semantically equal
BoD
force-pushed
the
fix-npe-when-catch-not-imported
branch
from
b671798
to
c503433
Compare
libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/Issue.kt
Outdated
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Outdated
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Outdated
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Outdated
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Outdated
Show resolved
Hide resolved
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Outdated
Show resolved
Hide resolved
...lo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/SchemaValidationScope.kt
Outdated
Show resolved
Hide resolved
…pollo3/ast/internal/SchemaValidationScope.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
...es/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo3/ast/internal/semanticEquals.kt
Show resolved
Hide resolved
Comment on lines
138
to
139
| private fun GQLDirective.isDefinedAndMatchesOriginalName(schema: Schema, originalName: String): Boolean { | ||
| return schema.directiveDefinitions.get(name) != null && schema.originalDirectiveName(name) == originalName |
There was a problem hiding this comment.
Apologies for nitpicking this but I'd rather have the codegen crash than silently ignore missing directive definitions.
All directive usage of @catch must be validated at that point so if we don't have a directive definition, it's a programming error that I'd rather catch (no pun intended) early
There was a problem hiding this comment.
Not sure why I had the impression it would still NPE without this, but it's not the case - just removed it 👍
|
Can you update the title/description of this PR ? |
BoD
changed the title
martinbonnin
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the definitions are "semantically equal".