Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-tooling] bump bootstraped version of Apollo to 4.0.0-beta.3 #5452

Merged
merged 14 commits into from Dec 15, 2023
Merged

[apollo-tooling] bump bootstraped version of Apollo to 4.0.0-beta.3 #5452

merged 14 commits into from Dec 15, 2023

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Dec 11, 2023 •
edited

Eat our own @catch food.

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 8ca4be3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/657b95bac2bfcf00087a39c1

BoD
BoD approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BoD
Copy link
Contributor

BoD commented Dec 13, 2023 •
edited

  • Field insights ✅
  • Telemetry ✅
  • Schema upload (monograph and subgraph cases) ✅
  • Schema download from registry ✅
  • Persisted queries upload ✅

@martinbonnin martinbonnin changed the title Add a Gradle test to download the schema against a real server [apollo-tooling] bump bootstraped version of Apollo to 4.0.0-beta.3 Dec 13, 2023
@martinbonnin
Copy link
Contributor Author

martinbonnin commented Dec 13, 2023 •
edited

I removed the Gradle test from this PR as the 4.0.0-beta.3 update is large enough to have its own PR.
Will open a separate PR for the Gradle test
Edit: it's here => #5478

BoD
BoD approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@martinbonnin
Copy link
Contributor Author

Made another pass at it. Looks like we can factor the error handling. See ApolloResponse.toException (source). Let me know what you think

BoD
BoD approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made another pass at it. Looks like we can factor the error handling. See ApolloResponse.toException (source). Let me know what you think

Yes looks good 👍

@martinbonnin martinbonnin merged commit 690ec85 into main Dec 15, 2023
9 checks passed
@martinbonnin martinbonnin deleted the introspection-test branch December 15, 2023 10:22
@martinbonnin
Copy link
Contributor Author

I merged this PR so it doesn't become stale and we can move forward with other PRs. Reminder to ourselves to re-test again using the integration test since there's been a few changes since your last tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinbonnin @BoD