Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mockserver] Allow to set the content-type of String responses #5489

Merged
merged 8 commits into from Dec 18, 2023

Conversation

martinbonnin
Copy link
Contributor

A bunch of mockserver fixes:

  • Allow to set the content-type of String responses
  • Fix reading content-length (it should be case insensitive)
  • More robust (albeit prone to false positive) handling of connection close

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit bec5d18
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/658050fadb740a00085c7c84

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin
Copy link
Contributor Author

I reverted the change to store headers lowercase as it could be surprising. As always, okhttp has a good API for headers but I decided to not go all-in because it's a breaking change and we're not really a HTTP library.

If we decide to make mockserver first class citizen, we should move it out of the repo and make the API better. Probably also share HttpEngine with the runtime.

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 109e2df into main Dec 18, 2023
9 checks passed
@martinbonnin martinbonnin deleted the content-type branch December 18, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants