[IJ Plugin] Inspection: missing directive import #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
...tlin/com/apollographql/ijplugin/inspection/ApolloMissingGraphQLDefinitionImportInspection.kt
Outdated
Show resolved
Hide resolved
...tlin/com/apollographql/ijplugin/inspection/ApolloMissingGraphQLDefinitionImportInspection.kt
Outdated
Show resolved
Hide resolved
...tlin/com/apollographql/ijplugin/inspection/ApolloMissingGraphQLDefinitionImportInspection.kt
Outdated
Show resolved
Hide resolved
...j-plugin/src/main/resources/inspectionDescriptions/ApolloMissingGraphQLDefinitionImport.html
Outdated
Show resolved
Hide resolved
intellij-plugin/src/main/resources/messages/ApolloBundle.properties
Outdated
Show resolved
Hide resolved
…loMissingGraphQLDefinitionImport.html Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Comment on lines
29
to
30
| const val CATCH = "catch" | ||
| const val CATCH_TO = "CatchTo" |
There was a problem hiding this comment.
For the record, we just discussed this and it would be better to not hardcode any definition names in AKIJP. Instead, AKIJP can read from the nullability and kotlin_labs definitions.
- unresolved
nullabilityimports are an error. - unresolved
kotlin_labsimports arean error too (TBC). 4.0 is lenient and imports them automatically but we should enforce this so might just be easier to have the same handling there.Edit: we finally decided on warning with a different warning to keep the IJ plugin contract matching the compiler contract
Aliased imports ({ name: "@catch", to: "mycatch" }`) cannot have a quick fix, which is expected, same as in Kotlin.
There was a problem hiding this comment.
kotlin_labs warning in latest commit:
Screen.Recording.2023-12-22.at.11.15.07.mov
intellij-plugin/src/main/resources/messages/ApolloBundle.properties
Outdated
Show resolved
Hide resolved
...j-plugin/src/main/resources/inspectionDescriptions/ApolloMissingGraphQLDefinitionImport.html
Outdated
Show resolved
Hide resolved
…rties Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…loMissingGraphQLDefinitionImport.html Co-authored-by: Martin Bonnin <martin@mbonnin.net>
...tlin/com/apollographql/ijplugin/inspection/ApolloMissingGraphQLDefinitionImportInspection.kt
Outdated
Show resolved
Hide resolved
Comment on lines
155
to
156
| extraSchemaFile.add(GraphQLElementFactory.createWhiteSpace(project, "\n\n")) | ||
| extraSchemaFile.add(it) |
There was a problem hiding this comment.
Can this be added at the top of the file instead, like other imports
There was a problem hiding this comment.
...tlin/com/apollographql/ijplugin/inspection/ApolloMissingGraphQLDefinitionImportInspection.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5413
Screen.Recording.2023-12-20.at.10.59.28.mov