HTTP Headers: remove X-APOLLO-OPERATION-NAME, X-APOLLO-OPERATION-ID and the multipart boundary
#5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
martinbonnin
commented
Feb 2, 2024
Comment on lines
-9
to
-21
| public static final field CACHE_DO_NOT_STORE Ljava/lang/String; | ||
| public static final field CACHE_EXPIRE_AFTER_READ_HEADER Ljava/lang/String; | ||
| public static final field CACHE_EXPIRE_TIMEOUT_HEADER Ljava/lang/String; | ||
| public static final field CACHE_FETCH_POLICY_HEADER Ljava/lang/String; | ||
| public static final field CACHE_FIRST Ljava/lang/String; | ||
| public static final field CACHE_KEY_HEADER Ljava/lang/String; | ||
| public static final field CACHE_ONLY Ljava/lang/String; | ||
| public static final field CACHE_OPERATION_TYPE_HEADER Ljava/lang/String; | ||
| public static final field CACHE_SERVED_DATE_HEADER Ljava/lang/String; | ||
| public static final field Companion Lcom/apollographql/apollo3/cache/http/CachingHttpInterceptor$Companion; | ||
| public static final field FROM_CACHE Ljava/lang/String; | ||
| public static final field NETWORK_FIRST Ljava/lang/String; | ||
| public static final field NETWORK_ONLY Ljava/lang/String; |
There was a problem hiding this comment.
Breaking change but this should have been internal from day 1
martinbonnin
added a commit
that referenced
this pull request
Feb 5, 2024
…D` and the multipart boundary (#5533) * use new router headers * remove X-APOLLO-OPERATION-NAME and X-APOLLO-OPERATION-ID * move docs to a separate PR * send apollo-require-preflight and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a effort to streamline the clients, we are modifying what headers are sent.
X-APOLLO-OPERATION-NAMEandX-APOLLO-OPERATION-IDare not required and are now opt-inAcceptheaderApollo-Require-Preflight: truefor simple HTTP request (i.e. GET and multupart/form-data uploads). See https://www.apollographql.com/docs/apollo-server/security/cors/#preventing-cross-site-request-forgery-csrf for more details.