Select all types in pre-introspection query #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
There was a problem hiding this comment.
Can we report that to GitHub? This feels sketchy especially given a "regular" introspection query will return more data.
In the meantime, I would change the query to make GitHub happy:
query PreIntrospectionQuery {
__schema {
types {
...TypeFields
}
}
}This should reasonably work, right?
martinbonnin
approved these changes
Jan 22, 2024
Comment on lines
-4
to
+8
| schema: __type(name: "__Schema") { ...TypeFields } | ||
| type: __type(name: "__Type") { ...TypeFields } | ||
| directive: __type(name: "__Directive") { ...TypeFields } | ||
| field: __type(name: "__Field") { ...TypeFields } | ||
| inputValue: __type(name: "__InputValue") { ...TypeFields } | ||
| __schema { | ||
| types { | ||
| ...TypeFields | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a comment linking to this PR?
BoD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.github.comdoesn't like querying too many introspection elements:{ "errors": [ { "type": "INTROSPECTION_LIMIT_EXCEEDED", "message": "Introspection fields may only be used 2 times, but some fields were used more than that: __Type.fields (5), __Field.args (5)" } ] }We can be lenient in that case, and still try to execute the basic introspection query.