[🐘gradle-plugin] deprecate schemaFile and sourceFolder #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
changed the title
martinbonnin
force-pushed
the
03-schema-configuration-cache
branch
from
eb3fdb8
to
81c3268
Compare
martinbonnin
force-pushed
the
04-deprecate-schemaFile-and-sourceFolder
branch
from
59cc9b0
to
de79928
Compare
martinbonnin
force-pushed
the
04-deprecate-schemaFile-and-sourceFolder
branch
from
06f1d14
to
d4e9944
Compare
✅ Deploy Preview for apollo-android-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
martinbonnin
added a commit
that referenced
this pull request
Feb 5, 2024
* Deprecate sourceFolder and schemaFile * replace our own usages of sourceFolder and schemaFile * fix bad copy/paste * fix bad search & replace * slightly tweak the docs * fromFrom -> from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schemaFileis problematic because it skipsextra.graphqlssourceFolderis duplicatingsrcDir()without allowing multiple directories + the fact that it's relative can be surprising (see #5550 (comment)).