[🐘gradle-plugin] use Worker API and ServiceLoader #5590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
force-pushed
the
serviceloader
branch
from
3152c37
to
2596be5
Compare
martinbonnin
added a commit
that referenced
this pull request
Feb 5, 2024
* add ServiceLoader * use workers * update compiler-hooks to use the compiler API * adapt operationIds test * restore * fix * update apiDump * hide kotlin-stdlib from the ApolloCompiler API so that the args are not relocatedd * fix integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Worker API and classloader isolation to load user plugins. Currently only done for
generateApolloSources.For backward compatibility with
packageNameGeneratorandoperationIdGenerator, classloader isolation is disabled if any of those is set.I'll remove hooks in a follow up PR as they were experimental, I think it's OK to remove them without going through deprecation cycles?