Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kotlin to 2.0.0-Beta4 #5624

Merged
merged 2 commits into from Feb 19, 2024
Merged

Bump Kotlin to 2.0.0-Beta4 #5624

merged 2 commits into from Feb 19, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Feb 15, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit b9528b3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65cddc0591a13300097e5276

martinbonnin
martinbonnin approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 🚀
Billion dollar question: does it work with K2?

@BoD
Copy link
Contributor Author

BoD commented Feb 15, 2024

does it work with K2?

I think almost there but:

  • 🔴 KT-21846 is not resolved yet and chokes on actual typealias ApolloTestResult = Promise<Any>
  • 🟠 KT-65105 is not resolved yet, but a simple workaround is to not override Executable methods in Operation and Fragment
  • 🟠 KT-60741 is either back or has never been resolved. There's also a simple workaround but I'll try to create a minimum reproducer.
  • 🟢 Need to bump kotlin-plugin-min = "1.9.0" for certain gradle tests to pass

@BoD
Copy link
Contributor Author

BoD commented Feb 15, 2024

Actually, KT-21846 is KT-60561 which has a workaround that works 🎉. With that I have integration tests passing on K2 ✅.

@BoD BoD merged commit 902729e into main Feb 19, 2024
9 checks passed
@BoD BoD deleted the kotlin-2.0.0-Beta4 branch February 19, 2024 09:21
martinbonnin pushed a commit that referenced this pull request Feb 27, 2024
@BoD @martinbonnin
Bump Kotlin to 2.0.0-Beta4 (#5624)
c5e6473 
* Bump Kotlin to 2.0.0-Beta4

* Opt-in ExperimentalWasmDsl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BoD @martinbonnin