Fix JS websocket throws an ISE on error on Safari and Firefox

[baconz]

We're seeing the error event fire when the websocket closes as a result of a network error on Safari and Firefox. Since the socket has already been opened, the coroutine has already been resumed and this throws an IllegalStateException ("Already resumed").

I can submit this same patch up to ktor, since I think that's where this code came from originally.

[netlify]

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ae01091

[BoD]

Looks good to me 👍 Thanks!

[martinbonnin]

Good catch!

Also looks like that code is still in Ktor indeed, a PR there would be great!

[martinbonnin]

PS: how hard would it be to add a test for that? I think KGP can do firefox tests with Karma?

[baconz]

I can take a stab at adding a test over the weekend!

[baconz]

Hmm. I'm afraid I'm a bit stumped on this one. The challenge is that you need a websocket server running outside of the browser that dies (uncleanly) after a connection has been established.

I think the easiest way to do this would be to have a little node script that runs the websocket server, which you start up beforehand (eg a shell-based gradle task with a dependsOn), and then kill it on a timer. That feels a little brittle, but I think it would work. I found this old gradle discussion with some code that purports to do this using an old Gradle plugin to manage the process.

Can you think of a better way? I found this very old Karma plugin, but I don't see an easy way to modify KotlinKarma to allow for custom plugins.

[martinbonnin]

Urg, right. No mock server in the browser :/. Not sure it's worth the extra complexity then, especially since the fix is solid. I'm merging this as is as we can revisit browser tests that need a MockServer next time. Thanks for looking at it!