Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume a single emission in AutoPersistedQueryInterceptor #5677

Merged
merged 1 commit into from Mar 5, 2024
Merged

Don't assume a single emission in AutoPersistedQueryInterceptor #5677

merged 1 commit into from Mar 5, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Mar 4, 2024

Resolves #5667

@BoD BoD requested a review from martinbonnin as a code owner March 4, 2024 13:31
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 375a31e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65e5cd3aca12020008e2b8f1

martinbonnin
martinbonnin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
There's a bunch of "interesting" edge cases if the PersistedQueriesNotFound is followed by other items in the original Flow. I don't think we need to be too concerned but mentioning just in case you think of something?

@BoD
Copy link
Contributor Author

BoD commented Mar 4, 2024

There's a bunch of "interesting" edge cases if the PersistedQueriesNotFound is followed by other items in the original Flow. I don't think we need to be too concerned but mentioning just in case you think of something?

Yeah I think it should "never" happen (with quotes because odd things tend to happen 😅). Worst case, it will re-query with the body even if it's not strictly necessary - I think that's OK.

@BoD BoD merged commit 7ecf7ac into main Mar 5, 2024
9 checks passed
@BoD BoD deleted the fix-defer-apq branch March 5, 2024 08:13
@BoD BoD mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental @defer support does not work with AutoPersistedQueryInterceptor
2 participants
@BoD @martinbonnin