Introduce incubating WebSocketNetworkTransport #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
force-pushed
the
04-websocket-network-transport
branch
from
3386922
to
3035a9a
Compare
martinbonnin
changed the title
Base automatically changed from
03-introduce-incubating-websocket-engine
to
main
March 5, 2024 09:21
martinbonnin
force-pushed
the
04-websocket-network-transport
branch
from
1e13985
to
eb4e6f4
Compare
✅ Deploy Preview for apollo-android-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an incubating
WebSocketNetwork. Disclaimer: this is 100% untested. It's not finished yet but it's relatively self contained so I'm making a separate PR.This PR introduces incubating:
WebSocketNetworkTransport: aNetworkTransportthat is a lot more simple than the non-incubating one. Theexecute()method in particular is just acallbackFlowWebSocketHolder: a class responsible to hold the websocketSubscribableWebSocket: the glue betweenWebSocketandWsProtocol. This is where most of the state machine isWsProtocoland implementations for AppSync, GraphqlWs, etc.. This is mostly unchanged from the non-incubating version.Missing: