Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Add hashKeyName option for createPersistedQueryLink #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infiniteluke
Copy link

@infiniteluke infiniteluke commented Jul 26, 2018

Hello! Thanks so much for building such a great library!

apollo-link-persisted-queries assumes your hash will be sha256, but provides generateHash function to override that which we assumed we’d use to pass our query names. However, It seems strange to send a string like page.v1 as the hash when it is not sha256.

Does that mean I’m using persisted queries in a way they’re not meant to be used or would you accept a PR that allows createPersistedQueryLink to take a hashKeyName to name that key differently?

@apollo-cla
Copy link

@infiniteluke: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the feature Feature: new addition or enhancement to existing solutions label Jul 26, 2018
@infiniteluke
Copy link
Author

Agreement signed ✅
Build is failing due to being .04KB above the limit 😉

@ghost ghost added the feature Feature: new addition or enhancement to existing solutions label Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature: new addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants