This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
Add ignoreOperations to not persist specific operations #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do? Allows
ignoreOperations
to specify an array of operations to ignore when persisting requests.Why? I came across an issue #12 with persisted queries and
apollo-upload-client
where the retried file upload would not include the files from the original request.There were some ideas thrown around here, but with no concrete solution. As the author pointed out, the issue comes from the fact that the library mutates the operation and the retry request does not have the correct payload.
Since this issue appeared to be unique to uploading files like this, I chose to add
ignoreOperations
to specify an Array of operations to ignore.Let me know if there's any improvements to be made, or if my approach is not worthwhile.