Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Allow graphql@16 as peer dependency #73

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Dec 15, 2021

Similar to #60 and should fix apollographql/apollo-client#9199.

I decided against actually updating the graphql dev dependency to v16 because there are other dev dependencies (like apollo-cache-inmemory) that don't currently accept graphql@16 as a peer dependency, and I don't want to fall down the rabbit-hole of updating every old AC2-era package (unless that's our only option).

Fortunately, this package makes limited use of the graphql package, so it is indeed still compatible with v16:

import { print } from 'graphql/language/printer';
import {
DefinitionNode,
DocumentNode,
ExecutionResult,
GraphQLError,
} from 'graphql';

I updated @types/graphql to its latest version to verify this usage of graphql is consistent with the latest types, at least.

@benjamn benjamn self-assigned this Dec 15, 2021
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution @benjamn - thanks very much!

@benjamn benjamn merged commit f15c5fd into master Dec 15, 2021
@benjamn benjamn deleted the admit-graphql-16-as-peer-dep branch December 15, 2021 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Pluralsight Course No Longer Builds Because of Dependency Error Introduced
2 participants