doc: fix composition doc (useless, obsolete Retry)

[fredericgermain]

Hi !

Updating this bit of documentation, it seems obsolete.

Another example which would be useful is the one in the client doc for subscription -> https://www.apollographql.com/docs/react/features/subscriptions.html

[apollo-cla]

@fredericgermain: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[codecov-io]

Codecov Report

Merging #555 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #555      +/-   ##
=========================================
+ Coverage   96.36%   96.4%   +0.03%     
=========================================
  Files          20      20              
  Lines         661     639      -22     
  Branches      155     157       +2     
=========================================
- Hits          637     616      -21     
+ Misses         19      17       -2     
- Partials        5       6       +1

Impacted Files	Coverage Δ
packages/apollo-link-error/src/index.ts	95.45% <0%> (-4.55%)	⬇️
packages/apollo-link-schema/src/schemaLink.ts	88.88% <0%> (-0.59%)	⬇️
packages/apollo-link-http-common/src/index.ts	92.42% <0%> (-0.23%)	⬇️
...ckages/apollo-link-batch-http/src/batchHttpLink.ts	98.14% <0%> (-0.07%)	⬇️
packages/apollo-link/src/link.ts	90.19% <0%> (ø)	⬆️
packages/apollo-link-http/src/httpLink.ts	100% <0%> (ø)	⬆️
packages/zen-observable-ts/src/zenObservable.ts	100% <0%> (ø)	⬆️
packages/apollo-link-retry/src/retryLink.ts	95.34% <0%> (+2.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57e9d5...50e3d39. Read the comment docs.

[evans]

@fredericgermain Thank you for opening the pull request! I'm curious what gave you the impression that this pattern is obsolete, since it should work as a common way of having retrying two different http links. Does it need a diagram?

Including the subscriptions example as well would be great! Could you make that change in this PR or another?

[fredericgermain]

There is no more Retry class is exported from apollo-link-retry package. It was renamed to RetryLink

cf

• https://github.com/apollographql/apollo-link/tree/master/packages/apollo-link-retry
• https://github.com/apollographql/apollo-link/blob/master/packages/apollo-link-retry/src/retryLink.ts

At the Retry/RetryLink would not bring anything useful here, it's better to have a simpler example in my opinion.

Or maybe I'm missing something?

[hwillson]

Thanks for this @fredericgermain! We're going to keep the RetryLink reference in the example, since we want to show how split can be called on another link. You're quite right about Retry being deprecated though, so I've updated your PR to replace the deprecated Retry references with RetryLink. Thanks again!