Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests + documentation to explain how to use this package with restify #125

Closed
rricard opened this issue Sep 7, 2016 · 4 comments
Closed

Comments

@rricard
Copy link

rricard commented Sep 7, 2016

Followup to #85.

Apollo Server works out-of-the-box with Restify 馃帀 .

We still need to ensure the compatibility with it: we need to ensure it won't break anytime soon so we need to provide both tests and documentation for this!

@helfer
Copy link
Contributor

helfer commented Sep 7, 2016

That's great news, thanks! Looking forward to the documentation and tests :)

@joelgriffith
Copy link

I'm interested in trying this out as well... Could you post what steps you've taken? I don't mind doing a PR for doc updates

@rricard
Copy link
Author

rricard commented Oct 19, 2016

@joelgriffith I couldn't work on that, but I can totally guide you in your contribution. The first thing to do, I think is to start with the tests: take the express tests and adapt them to use restify in there instead. Commit, push and create the pr early so I can help you along the way! 馃槈 Thank you!

@joelgriffith
Copy link

@rricard #179 馃挜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants