Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError on tracer method #25

Closed
jbaxleyiii opened this issue Jun 13, 2016 · 2 comments
Closed

TypeError on tracer method #25

jbaxleyiii opened this issue Jun 13, 2016 · 2 comments

Comments

@jbaxleyiii
Copy link
Contributor

Tracer.submit is not a function

https://github.com/apollostack/apollo-server/blob/master/src/apolloServer.js#L254
@helfer
Copy link
Contributor

helfer commented Jun 13, 2016

I think the problem is here:

https://github.com/apollostack/apollo-server/blob/853ebfbda3360104c505073d3b17c0905cefc3eb/src/apolloServer.js#L138

I'm a bit confused as to why that hasn't caused any test to fail, tbh.

Also, might be worth noting here that the tracer code itself is no longer in apollo server. You have to import it from the apollo-tracer pacakge.

@helfer
Copy link
Contributor

helfer commented Jun 13, 2016

Fixed by #26

@helfer helfer closed this as completed Jun 13, 2016
trevor-scheer pushed a commit that referenced this issue May 6, 2020
@JakeDawkins @trevor-scheer
Add validation for @external, @requires, @key, restricted default roo…
9b65101 
…t operation names (#25)

* Add validation for @key directives

* Added validation rules for @externals and @requires directives

* Added jest-config and graphql-tag dev dependencies

* exported composition functions

* Validate against invalid usage of root operation type names
Add a validator to warn users against using default root operation
type names when they've specified non-default root operation types.

* Update externals error message

* Add union type handling and update related tests / edge cases.
trevor-scheer pushed a commit that referenced this issue May 14, 2020
@JakeDawkins @trevor-scheer
Add validation for @external, @requires, @key, restricted default roo…
c0e3827 
…t operation names (#25)

* Add validation for @key directives

* Added validation rules for @externals and @requires directives

* Added jest-config and graphql-tag dev dependencies

* exported composition functions

* Validate against invalid usage of root operation type names
Add a validator to warn users against using default root operation
type names when they've specified non-default root operation types.

* Update externals error message

* Add union type handling and update related tests / edge cases.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbaxleyiii @helfer