Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-server-restify]: restify is outdated #472

Closed
williamhub opened this issue Jul 20, 2017 · 2 comments
Closed

[apollo-server-restify]: restify is outdated #472

williamhub opened this issue Jul 20, 2017 · 2 comments

Comments

@williamhub
Copy link

The current restify version is outdated. Since its type def changed a little bit, the current demo example doesn't work. It will throw type errors for server.post("/graphql", graphqlRestify(graphQLOptions)):

Argument of type 'RestifyHandler' is not assignable to parameter of type 'RequestHandlerType'.

I would love to do a quick update PR on this, and please let me know if you guys currently work on it.
@martijnwalraven
Copy link
Contributor

Thanks for letting us know. I don't think anyone is currently working on this, so a PR is definitely welcome!

@williamhub williamhub mentioned this issue Jul 21, 2017
Merged
@martijnwalraven
Copy link
Contributor

This has just been published in Apollo Server 1.1.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martijnwalraven @williamhub