Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-core@3.6.0 is trying to import now removed apollo-graphql dependency #5980

Closed
sushantdhiman opened this issue Dec 31, 2021 · 2 comments · Fixed by #5981
Closed

Comments

@sushantdhiman
Copy link
Contributor

For fixing #5941, PR #5955 removed the apollo-graphql package from dependencies and inlined some code from that package. But it seems not all instances of apollo-graphql were removed.

For example

import { defaultUsageReportingSignature } from 'apollo-graphql';

Above file is still trying to import apollo-graphql, forcing builds to fail with following error

{
      detail: undefined,
      location: {
        column: 33,
        file: 'node_modules/apollo-server-core/dist/plugin/usageReporting/plugin.js',
        length: 16,
        line: 10,
        lineText: 'const apollo_graphql_1 = require("apollo-graphql");',
        namespace: '',
        suggestion: ''
      },
      notes: [
        {
          location: null,
          text: 'You can mark the path "apollo-graphql" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.'
        }
      ],
      pluginName: '',
      text: 'Could not resolve "apollo-graphql"'
    }
@glasser
Copy link
Member

glasser commented Dec 31, 2021

Yikes, good catch. Will fix tomorrow in a 3.6.1 (about to go to sleep). Feel free to send a PR to fix the import to the newly added file if you'd like!

@glasser
Copy link
Member

glasser commented Dec 31, 2021

Thanks, fixed in v3.6.1.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants