Skip to content

Commit

Permalink
Support validation parameters for service:check (#953)
Browse files Browse the repository at this point in the history
* Add historic flags for the service:check command

* validationPeriod - the duration (from now) to validate the service against
* queryCountThreshold - minimum number of requests within the requested time window for a query to be considered
* queryCountThresholdPercentage - number of requests within the requested time window for a query to be considered, relative to total request count.

* Improve error reporting and fix out-of-order error throwing.

Throw errors from the response if we have them, then throw the generic
error if no data is provided. Previously, the order of these were swapped,
meaning that if a specific error came back from the server, we would still
throw the generic error.

* Update changelog
  • Loading branch information
trevor-scheer committed Feb 6, 2019
1 parent 3e2627b commit 1b53b1e
Show file tree
Hide file tree
Showing 7 changed files with 363 additions and 117 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Upcoming

- `apollo`
- Support validation parameters for service:check [#953](https://github.com/apollographql/apollo-tooling/pull/953)
- `apollo-language-server`
- Better error handling in ApolloEngineClient [#953](https://github.com/apollographql/apollo-tooling/pull/953)

## `apollo@2.4.4`, `apollo-codegen-scala@0.33.0`

- `apollo@2.4.4`
Expand Down
Loading

0 comments on commit 1b53b1e

Please sign in to comment.