Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operation-ids-path option is broken (Swift) #280

Closed
kompfner opened this issue Oct 25, 2017 · 3 comments
Closed

operation-ids-path option is broken (Swift) #280

kompfner opened this issue Oct 25, 2017 · 3 comments
Assignees

Comments

@kompfner
Copy link
Contributor

When passed in an --operation-ids-path, apollo-codegen should generate a file mapping between operation ids and operation sources (including dependent fragments). This functionality was added as part of #147.

This functionality is now broken. Running apollo-codegen with the --operation-ids-path argument yields TypeError: path must be a string or Buffer.

There are two problems, as far as I can tell. In writeOperationIdsMap in generate.ts:

  1. context no longer contains operationIdsPath
  2. Each operation in context.operations no longer contains operationId or sourceWithFragments

My guess is that this broke as a result of the changes in #228.

@kompfner kompfner changed the title operation-ids-path option is broken operation-ids-path option is broken (Swift) Oct 25, 2017
@martijnwalraven
Copy link
Contributor

I'm sorry the compiler rewrite broke the --operation-ids-path feature, but since you are the only one using it, and you know what is needed, could you open a PR to fix this?

@inakianduaga
Copy link

I can confirm this is still broken

@JustinDSN
Copy link
Contributor

I put up a PR to address this issue.

ecstasy2 added a commit to ecstasy2/apollo-codegen that referenced this issue Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants