Introduced type keyword among the ones that need to be escaped
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espinhogr
force-pushed
the
safe_scalajs_parameter_names
branch
2 times, most recently
from
5d23249
to
730ee98
Compare
|
I don't know why Generated Types Check is not passing as I haven't touched the typescript generation at all. |
|
@espinhogr thanks for the PR! Looks like it just needs a rebase against |
…hat need to be escaped
espinhogr
force-pushed
the
safe_scalajs_parameter_names
branch
from
730ee98
to
67adb9d
Compare
|
@trevor-scheer I've just rebased to the master but it seems to fail in a test on Windows, is this something known or you think it's the change I've introduced? |
|
@espinhogr we've got something flaky in the tests, I re-ran and it looks good. Thanks again! |
|
@trevor-scheer Brilliant, happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Tests are only there for the general case and not for each single keyword
Fixes: #1065