Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo: add debug statements to service:check #1250

Merged
merged 1 commit into from
May 8, 2019

Conversation

evans
Copy link
Contributor

@evans evans commented May 8, 2019

Currently there isn't an easy way to determine the variables sent to
engine by the apollo service:check command. This adds the ability to
turn on debug mode and print out those commands.

In order to show the statements, run DEBUG=* apollo service:check

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

Currently there isn't an easy way to determine the variables sent to
engine by the apollo service:check command. This adds the ability to
turn on debug mode and print out those commands.

In order to show the statements, run `DEBUG=* apollo service:check`

add changelog entry
@evans evans force-pushed the evans/add-service-check-debug branch from 2de56f9 to ad6050a Compare May 8, 2019 22:40
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evans evans merged commit 7af0948 into master May 8, 2019
@evans evans deleted the evans/add-service-check-debug branch May 8, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants