Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service:list snapshot relative time #1374

Merged
merged 2 commits into from Jul 3, 2019
Merged

Fix service:list snapshot relative time #1374

merged 2 commits into from Jul 3, 2019

Conversation

justinanastos
Copy link
Contributor

The time is relative; over time the value changes, causing the snapshot to
fail.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@justinanastos
Fix service:list snapshot relative time
7479044 
The time is relative; over time the value changes, causing the snapshot to
fail.
@justinanastos justinanastos merged commit 5e1e44f into master Jul 3, 2019
@justinanastos justinanastos deleted the justin/fix-relative-time-snapshot-failure branch July 3, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

@mayakoneval mayakoneval Awaiting requested review from mayakoneval

@JakeDawkins JakeDawkins Awaiting requested review from JakeDawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinanastos @trevor-scheer