Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change status bar name #1415

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Change status bar name #1415

merged 1 commit into from
Jul 18, 2019

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Jul 18, 2019 •
edited

"Apollo GraphQL" is a little verbose for the limited space on the status bar. This just renames it to "Apollo"

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins added 🎉 feature New addition or enhancement to existing solutions 🗒️ component - vscode related to editor tooling labels Jul 18, 2019
@JakeDawkins JakeDawkins merged commit 2243faa into master Jul 18, 2019
@JakeDawkins JakeDawkins deleted the jake/rename-status-bar branch July 18, 2019 16:19
essaji pushed a commit to essaji/apollo-tooling that referenced this pull request Aug 25, 2019
@JakeDawkins @essaji
[VSCODE] Change status bar name to Apollo (apollographql#1415)
e493341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

Assignees
No one assigned
Labels
🗒️ component - vscode related to editor tooling 🎉 feature New addition or enhancement to existing solutions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeDawkins @trevor-scheer