service:check add null check for validation config #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evans this looks good to me! Can you update the tests for this? |
added 3 commits
August 21, 2019 11:04
The validationConfig is set to null when the backend does not perform any validations. This reformats the markdown output to reflect that
evans
force-pushed
the
evans/add-null-check-for-validationConfig
branch
from
74ab4ce
to
3d99cc0
Compare
JakeDawkins
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validationConfig is set to null when the backend does not perform
any validations. This reformats the markdown output to reflect that
closes #1243
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.