Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "table" package for tabular output and word wrap support #1524

Merged
merged 6 commits into from
Sep 25, 2019

Conversation

trevor-scheer
Copy link
Member

Federation results in particular can be quite long, causing some
word wrap pandemonium. This package supports word wrap and a
provides a cleaner look overall for tabular output.

This PR does not replace all usages of heroku-cli-utils table function.
For output that is currently untested or that I couldn't test manually, I didn't
make the switch.

Successful service:check
image

Failing service:check
image

service:list
image

Successful service:push
image

Failing service:push
image

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

trevor-scheer and others added 5 commits September 25, 2019 12:28
Federation results in particular can be quite long, causing some
word wrap pandemonium. This package supports word wrap and a
provides a cleaner look overall.
@JakeDawkins
Copy link
Contributor

JakeDawkins commented Sep 25, 2019

apollo client:push updates:

  • i made failures a table, but didn't put the filepath in the table, since wrapping of the filename makes the filename unclickable
  • I removed the filename from successes, since that shouldn't matter

Screen Shot 2019-09-25 at 12 33 54 PM

(ignore the `WIDTH=` printout, that was just in there during debugging)

Screen Shot 2019-09-25 at 12 34 07 PM

@trevor-scheer trevor-scheer merged commit 1d0b614 into master Sep 25, 2019
@trevor-scheer trevor-scheer deleted the trevor/change-table-usage branch September 25, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants