Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --graph flag #1858

Merged
merged 13 commits into from
Mar 30, 2020
Merged

Add support for --graph flag #1858

merged 13 commits into from
Mar 30, 2020

Conversation

zionts
Copy link
Contributor

@zionts zionts commented Mar 28, 2020

This PR adds support for the --graph (alias -g) flag to all commands. This will allow users to specify a graph without needing to create an apollo.config.js file, which will lead to a smoother on-boarding ramp for first-time users. Additionally, this PR contains a bug fix for apollo.config.js files of the service type, where specifying a variant is supported equally as to client projects.

For example, a config like so:

module.exports = {
  service: {
    name: github@prod
  }
}

will be parsed as graph = github , variant = prod, just as with client projects (which were supported in that fashion before this PR)

There aren't tests for any of the client: commands, but I added a test for the additional functionality and did manual QA of my changes. Here is a small sampling and happy to provide additional:

service:list working with a --graph flag and a user token:
image

client:check working with a --graph flag and an apollo.config.js that does not have a service key:
image

client:codegen working with a --graph flag and an apollo.config.js that does not have a service key:
image

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

Adam Zionts added 13 commits March 28, 2020 00:00
This commit adds a --graph flag (alias -g) which can be set for all CLI
commands. There is no handling in this commit.
Additionally, run prettier, do some minor clean-up and inlining of
variables that are only used once
Also support servicee specifier in the service.name field
Prettier did this. I blame prettier.
Also add a test to that effect
@zionts zionts marked this pull request as ready for review March 28, 2020 09:50
@zionts zionts requested a review from JakeDawkins March 28, 2020 09:50
@zionts zionts changed the title Add support for --graph flag (and bug fixes) Add support for --graph flag Mar 28, 2020
@JakeDawkins JakeDawkins self-assigned this Mar 30, 2020
Copy link
Contributor

@JakeDawkins JakeDawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants