Align codegen and language server inline fragment __typename use #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
typename-fragment-issue
branch
2 times, most recently
from
9c414e3
to
21730c0
Compare
The `withTypenameFieldAddedWhereNeeded` utility in `apollo-language-server` was updated in #1286 to make sure `__typename`'s are added to inline fragments, when used by commands like `client:push`. The `apollo-codegen-core` package currently uses its own copy of `withTypenameFieldAddedWhereNeeded` however, which was not updated. This means that operations can be registered (in Apollo's operation registry) via `client:push` that don't line up with the operations output by codegen. This commit adjusts the `apollo-codegen-core` package to use the same `withTypenameFieldAddedWhereNeeded` function as `apollo-language-server` (which is already a dependency of codegen), to make sure the operations output from codegen line up with the operations pushed via `client:push`.
hwillson
force-pushed
the
typename-fragment-issue
branch
from
21730c0
to
39a70fb
Compare
trevor-scheer
approved these changes
Nov 11, 2021
calvincestari
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withTypenameFieldAddedWhereNeededutility inapollo-language-serverwas updated in #1286 to make sure__typename's are added to inline fragments, when used by commands likeclient:push. Theapollo-codegen-corepackage currently uses its own copy ofwithTypenameFieldAddedWhereNeededhowever, which was not updated. This means that operations can be registered (in Apollo's operation registry) viaclient:pushthat don't line up with the operations output by codegen.This commit adjusts the
apollo-codegen-corepackage to use the samewithTypenameFieldAddedWhereNeededfunction asapollo-language-server(which is already a dependency of codegen), to make sure the operations output from codegen line up with the operations pushed viaclient:push.