Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support validation parameters for service:check #953

Merged
merged 3 commits into from
Feb 6, 2019
Merged

Support validation parameters for service:check #953

merged 3 commits into from
Feb 6, 2019

Commits on Feb 6, 2019

  1. Add historic flags for the service:check command 

    * validationPeriod - the duration (from now) to validate the service against
* queryCountThreshold - minimum number of requests within the requested time window for a query to be considered
* queryCountThresholdPercentage - number of requests within the requested time window for a query to be considered, relative to total request count.
    @trevor-scheer
    trevor-scheer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    48dcbd1 View commit details
    Browse the repository at this point in the history

  2. Improve error reporting and fix out-of-order error throwing. 

    Throw errors from the response if we have them, then throw the generic
error if no data is provided. Previously, the order of these were swapped,
meaning that if a specific error came back from the server, we would still
throw the generic error.
    @trevor-scheer
    trevor-scheer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    69580fb View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @trevor-scheer
    trevor-scheer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1399b04 View commit details
    Browse the repository at this point in the history