-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes MultiCodeBlock highlighting consistency issue #182
Conversation
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work correctly from where I'm sitting!
aaaa12d
to
ff2f9af
Compare
08ada63
to
c554b8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @BlenderDude! Just noticed a few things and left some comments/suggestions. Let me know if that all makes sense 🙇
fab6373
to
af4867a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍣
Highlighting line consistency was lost during the TS->JS transpilation.
In the old system, line 1 would be omitted in the JS output, leaving
test()
to be highlighted. This was incorrect behavior and is adjusted with this new system to track line highlights.More can be seen in the tests of the
remark-typescript
project remark-typescriptScreen.Recording.2022-08-11.at.4.32.03.PM.mov
The above video properly shows the new highlighting adjustment. Note how the interface is highlighted in TS, and is now properly adjusted for and collapsed for JS.