Updated remark parsing and added extra code block props #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlenderDude
requested review from
StephenBarlow and
rkoron007
as code owners
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jgarrow
approved these changes
Sep 7, 2022
Comment on lines
80
to
86
| const bumpScroll = (distance: number) => () => { | ||
| if (!outerRef) return; | ||
| outerRef.current.scrollBy({ | ||
| outerRef.current?.scrollBy({ | ||
| left: distance, | ||
| behavior: 'smooth' | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Out of scope for this PR, but I'm wondering about the accessibility of the tabs for screen readers? I haven't tried it with my screen reader yet, but perhaps something we can discuss.
There was a problem hiding this comment.
I did my best to follow the guidelines laid out here (https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-manual.html). So hitting tab should be able to move between tabs, but one thing I did not consider is the highlighted element might end up "out of view" because of the scrolling. Definitely something we should look into and discuss!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated typescript remark parser to fix pattern matching issue found in some imports for TS code blocks. See below (yes there are import statements at the end of a couple hundred comment tokens 😄 )
This update also introduces additional props to the
CodeBlockcomponent and implements a fallback to "local" tabs if the global context is not available. Useful for things other than the docs!