Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema proposal webhooks #839

Merged
merged 23 commits into from
May 28, 2024
Merged

Add schema proposal webhooks #839

merged 23 commits into from
May 28, 2024

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Apr 23, 2024 •
edited

This PR:

  • Adds docs for schema proposal notifications
  • Componentizes instructions for setting up notifications so they can be repeated on each notification type's page, rather than requiring readers to have both the general setup page and the notification type page open

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

❌ Deploy Preview for apollo-monodocs failed.

Name Link
🔨 Latest commit e17bb77
🔍 Latest deploy log https://app.netlify.com/sites/apollo-monodocs/deploys/6655e3d01f9aaf000812da47

@Meschreiber Meschreiber changed the title [WIP] Add schema proposal webhooks Add schema proposal webhooks Apr 25, 2024
@Meschreiber Meschreiber marked this pull request as ready for review April 25, 2024 14:45
@Meschreiber Meschreiber requested a review from a team as a code owner April 25, 2024 14:45
cy
cy approved these changes May 2, 2024
View reviewed changes
Copy link

@cy cy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! thank you so much! I'll let you know when the feature flag is flipped so you can merge at the same time :)

@Meschreiber Meschreiber merged commit 465f0a9 into main May 28, 2024
5 of 9 checks passed
@Meschreiber Meschreiber deleted the ms/add-schema-proposal-webhooks branch May 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cy cy cy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Meschreiber @cy