Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use implicit binding for federated POCO #39

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: use implicit binding for federated POCO #39

merged 3 commits into from
Oct 31, 2023

Conversation

dariuszkuc
Copy link
Member

Generation of a Federated schema would fail if using explicit bindings. Updated directive representation POCO to always use implicit binding.

Added example of a CodeFirst solution using BindingBehavior.Explicit (and added some missing descriptor extension functions).

Resolves: #35

@dariuszkuc dariuszkuc marked this pull request as ready for review October 30, 2023 21:16
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@dariuszkuc
Copy link
Member Author

@michael-watson do we still need example projects (examples folder)?

Generation of a Federated schema would fail if using explicit bindings. Updated directive representation POCO to always use implicit binding.

Added example of a CodeFirst solution using `BindingBehavior.Explicit` (and added some missing descriptor extension functions).
@dariuszkuc dariuszkuc merged commit 762d9d0 into main Oct 31, 2023
4 checks passed
@dariuszkuc dariuszkuc deleted the binding branch October 31, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unable to setup server with AddApolloFederationV2
1 participant