use GraphQLAppliedDirective instead of GraphQLDirective for printing FederationSDL #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagliyvred
requested review from
sachindshinde,
martinbonnin,
BoD and
dariuszkuc
as code owners
|
@nagliyvred: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
👋 thanks for raising this, indeed it looks like I missed it when I fixed the entity lookup logic in #214. That SDL printer is a copy from Two considerations
Would you be willing to update the printer to the latest https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/idl/SchemaPrinter.java? |
dariuszkuc
added a commit
to dariuszkuc/federation-jvm
that referenced
this pull request
Jul 27, 2022
`FederationSdlPrinter` is a copy of a `graphql.schema.idl.SchemaPrinter` from `graphql-java` v17 with some custom filtering logic that was required for Federation v1. `graphql-java` v18 introduced concept of applied directive to make a distinction from the directive definition (previously same `GraphQLDirective` type was used for both). This PR drops our custom copy of the schema printer and instead updates our logic to rely on the built-in schema printer provided by the `graphql-java`. Using custom predicates for filtering directives and schema elements we can replicate our custom functionality without the need of a custom printer. Related: * resolves: apollographql#227 * resolves: apollographql#216 * supersedes: apollographql#223
|
Superseded by #231 |
dariuszkuc
added a commit
that referenced
this pull request
Jul 28, 2022
`FederationSdlPrinter` is a copy of a `graphql.schema.idl.SchemaPrinter` from `graphql-java` v17 with some custom filtering logic that was required for Federation v1. `graphql-java` v18 introduced concept of applied directive to make a distinction from the directive definition (previously same `GraphQLDirective` type was used for both). This PR drops our custom copy of the schema printer and instead updates our logic to rely on the built-in schema printer provided by the `graphql-java`. Using custom predicates for filtering directives and schema elements we can replicate our custom functionality without the need of a custom printer. Related: * resolves: #227 * resolves: #216 * supersedes: #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest graphql-java is reimplementing directives graphql-java/graphql-java#2562 and moving to GraphQLAppliedDirective instead.
Similarly, graphql-java-kickstart project is being updated to make use of GraphQLAppliedDirective too graphql-java-kickstart/graphql-java-tools#663 .
This breaks federation, as the schema built with the latest graphql-java-tools would not contain any GraphQLDirective and therefore generated SDL is going to have all of the federation-related directives missing.
This PR is meant to address it by getting FedarationSdlPrinter to use the new directive classes everywhere, except where the actual directive definition is printed.