spring-example pom.xml: assembly plugin #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zionts
approved these changes
Sep 13, 2019
|
I see you already list "springboot-maven-plugin", so why not use that (https://docs.spring.io/spring-boot/docs/current/maven-plugin/repackage-mojo.html) instead. The repackage mojo is the way recommended by Spring for this. |
Allows for: ``` $ mvn package && java -jar spring-example/target/federation-spring-example-0.2.1-SNAPSHOT-jar-with-dependencies.jar ```
pcarrier
force-pushed
the
pcarrier/assembly_for_spring-example
branch
from
aee905e
to
2c6a856
Compare
|
@lqc Sounds better, thanks, dropping this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for:
We should confirm the artifacts do not get attached for upload.
Should update README.md to reflect the option.