Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECOPS-2268: Add Gitleaks to CI #356

Merged
merged 1 commit into from
Oct 11, 2023
Merged

SECOPS-2268: Add Gitleaks to CI #356

merged 1 commit into from
Oct 11, 2023

Conversation

svc-secops
Copy link
Contributor

Motivation / Implements

This PR adds the necessary files to configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.

Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.

In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.

If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.

Changed

  • Added .circleci/config.yml to this repo. This file contains appropriate configuration to enable Gitleaks as a CI check.

@github-actions
Copy link

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@dariuszkuc dariuszkuc marked this pull request as ready for review October 11, 2023 19:16
@dariuszkuc dariuszkuc merged commit a1278b7 into main Oct 11, 2023
3 checks passed
@dariuszkuc dariuszkuc deleted the secops/add-gitleaks branch October 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants