Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(callback): support configurable heartbeat interval #360

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

dariuszkuc
Copy link
Member

@dariuszkuc dariuszkuc commented Nov 22, 2023

Update protocol to support configurable heartbeat interval. In order to keep backwards compatibility with older version of protocol, if no heartbeat value is provided, we default to 5s.

Updated protocol to also support both camelCase and snake_case extension values.

Update protocol to support configurable heartbeat interval.
Copy link

github-actions bot commented Nov 22, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@bnjjj
Copy link

bnjjj commented Nov 23, 2023

I think that would be interesting to handle the case when heartbeat_interval_ms is not provided. To have a smooth transition for people using an older version of the router and stay backward compatible during few weeks. What do you think @dariuszkuc ?

@dariuszkuc dariuszkuc merged commit 9cc070c into main Nov 27, 2023
4 checks passed
@dariuszkuc dariuszkuc deleted the heartbeat branch November 27, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change: minor New functionality added in backwards compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants