graphql-java-support: Bump graphql-java to v14

[sachindshinde]

This PR is an iteration of the changes suggested in #41 and #46 (many thanks to the authors and commenters).

Summary of changes:

• Bump graphql-java to V14 in pom.xml
• Change GraphQLType::getName() to GraphQLNamedType::getName()
  • Reason: graphql-java changed their type hierarchy
• Change SchemaPrinter.Options.includeSchemaDefintion() to includeSchemaDefinition()
  • Reason: graphql-java fixed a typo in the word "definition"
• Change RuntimeWiring.getSchemaTransformers() to RuntimeWiring.getSchemaGeneratorPostProcessings()
  • Reason: graphql-java changed the getter name
• Prevent standard directive definitions (@deprecated, @include, and @skip) from appearing in the SDL
  • Reason: graphql-java now includes these definitions in the schema printer by default (due to Changes in schema directive printing AND the comment formats graphql-java/graphql-java#1609 ), which breaks gateway composition
• Update FederationSdlPrinter to use graphql-java v14's SchemaPrinter
  • Reason: As described in graphql-java-support: Fix grammar violation in graphql-java's SchemaPrinter #52 , a bug in graphql-java's SchemaPrinter forces us to maintain our own copy (FederationSdlPrinter), but with the bugs fixed. As described in graphql-java-support: Remove federation directive and type definitions from SDL and use stricter SchemaGenerator checks #53 , we also use our own printer to avoid printing federation directive definitions and federation type definitions in SDL.

Note this is a backwards-incompatible change.

Also note that FederationSdlPrinter.Options.includeDirectives() will filter all directive definitions and usages indicated with the exception of directive usages of @deprecated, which is conveniently the behavior we want. We've added directive definition filtering in #53 , so we don't need to rely on FederationSdlPrinter.Options.includeDirectives() to filter the standard directive definitions.

It'll be easier in this PR to go commit-by-commit. For FederationSdlPrinter, it'll help to compare FederationSdlPrinter.java in the class-copy-and-rename commit to the v14 SchemaPrinter, located at https://raw.githubusercontent.com/graphql-java/graphql-java/v14.0/src/main/java/graphql/schema/idl/SchemaPrinter.java . For the FederationSdlPrinter changes that fix the issues in #52 and #53 , it'll help to compare against the respective changes in those PRs.

[mcohen75]

Also note that SchemaPrinter.Options.includeDirectives() will filter all directive definitions and usages indicated with the exception of directive usages of @deprecated, which is conveniently the behavior we want.

Is it worth adding a test to ensure that the @skip and @include directives are filtered out? This would catch problems here in the future if this behavior changes in graphql-java. It would also serve as convenient documentation when we all forget about this PR.

[sachindshinde]

@mcohen75
@include and @skip can only be used on executable locations (as per spec), and not type system locations. The only way we could test is by including executable definitions, but SchemaParser.parse() will naturally throw if it sees those.

[zionts]

Thank you for the detailed PR description! I think we should try to use this ourselves in our own federated service before merging this, but I'll take a look at the FederationSdlPrinter changes more thoroughly now. Everything else looks 👍

[sachindshinde]

So after some testing in our own infra, I've opened up #53 to address some further issues, and rebased this branch on top of that.

The main consequences for this PR are that we can just use the directive definition filtering from #53 to hide standard directive definitions.