Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

[Plan Selection] Option pruning for closed branches #116

Closed
sachindshinde opened this issue Dec 18, 2023 · 0 comments · Fixed by #117
Closed

[Plan Selection] Option pruning for closed branches #116

sachindshinde opened this issue Dec 18, 2023 · 0 comments · Fixed by #117
Assignees
@SimonSapin
Milestone
QP Preview (Relea...

Comments

@sachindshinde
Copy link
Contributor

Port the logic for options pruning from the JS codebase to Rust. That is, port these methods on QueryPlanningTraversal:

It'll help to look at the comments in this section of code, which explains more about those functions in the context in which they're called.

Part of #77.
@sachindshinde sachindshinde added this to the QP Preview (Release 1) milestone Dec 18, 2023
SimonSapin added a commit that referenced this issue Dec 18, 2023
@SimonSapin
[Plan Selection] Option pruning for closed branches
df8b0ca 
Fixes #116
SimonSapin added a commit that referenced this issue Dec 18, 2023
@SimonSapin
[Plan Selection] Option pruning for closed branches
1ea212f 
Fixes #116
@SimonSapin SimonSapin mentioned this issue Dec 18, 2023
Merged
sachindshinde pushed a commit that referenced this issue Jan 15, 2024
@SimonSapin
[Plan Selection] Option pruning for closed branches (#117)
fadfee2 
Fixes #116
SimonSapin added a commit to apollographql/router that referenced this issue May 3, 2024
@SimonSapin
[Plan Selection] Option pruning for closed branches (apollographql/fe…
6772428 
…deration-next#117)

Fixes apollographql/federation-next#116
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
QP Preview (Release 1)
Development

Successfully merging a pull request may close this issue.

[Plan Selection] Option pruning for closed branches apollographql/federation-next
2 participants
@SimonSapin @sachindshinde