Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Benchmark with and without prune_closed_branches #131

Closed
SimonSapin opened this issue Jan 9, 2024 · 0 comments
Closed

Benchmark with and without prune_closed_branches #131

SimonSapin opened this issue Jan 9, 2024 · 0 comments
Labels
enhancement New feature or request performance
Milestone
QP Preview (Relea...

Comments

@SimonSapin
Copy link
Contributor

SimonSapin commented Jan 9, 2024 •
edited by abernix

This ticket has been moved to https://apollographql.atlassian.net/browse/FED-19.

The TypeScript implementation got faster in at least some cases by removed it apollographql/federation#2905. The Rust implementation has slightly different data structures and memory layout, so let’s measure whether removing would be an improvement there or not.
@SimonSapin SimonSapin added the enhancement New feature or request label Jan 9, 2024
@lrlna lrlna added this to the QP GA (Release 2) milestone Jan 9, 2024
@SimonSapin SimonSapin mentioned this issue Jan 16, 2024
Merged
@SimonSapin SimonSapin changed the title Benchmark with and without prune_closed_branches [perf] Benchmark with and without prune_closed_branches Jan 19, 2024
@SimonSapin SimonSapin changed the title [perf] Benchmark with and without prune_closed_branches Benchmark with and without prune_closed_branches Jan 19, 2024
@abernix abernix closed this as completed Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
QP Preview (Release 1)
Development

No branches or pull requests
3 participants
@SimonSapin @abernix @lrlna